[
https://issues.apache.org/jira/browse/HDFS-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045052#comment-13045052
]
Todd Lipcon commented on HDFS-1149:
-----------------------------------
It seems to me that the new condition for safe mode check in
internalReleaseLease should actually be an assert, right?
The two call paths into internalReleaseLease are:
- FSNamesystem.startFileInternal, which checks safeMode at the top
- LeaseManager.checkLeases(), which is called from LeaseManager.Monitor inside
a check against safemode
so, any call of internalReleaseLease not in safe mode would be a real bug,
right?
Otherwise looks good.
> Lease reassignment is not persisted to edit log
> -----------------------------------------------
>
> Key: HDFS-1149
> URL: https://issues.apache.org/jira/browse/HDFS-1149
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Todd Lipcon
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: editsStored, hdfs-1149.0.patch, hdfs-1149.1.patch,
> hdfs-1149.1.patch
>
>
> During lease recovery, the lease gets reassigned to a special NN holder. This
> is not currently persisted to the edit log, which means that after an NN
> restart, the original leaseholder could end up allocating more blocks or
> completing a file that has already started recovery.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
