[
https://issues.apache.org/jira/browse/HDFS-12714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233549#comment-16233549
]
Joe McDonnell commented on HDFS-12714:
--------------------------------------
[~jzhuge]
The test case that spurred the creation of this JIRA is an Impala test case for
Impala's fallback code when a zero copy HDFS read fails.
It does this by mixing zero copy reads with encryption zones, which is a known
error case (see IMPALA-3679). That error causes libhdfs to call
translateZCRException, which without this patch was failing and crashing
Impala.
I tested this patch by building libhdfs and running the same test case. It
succeeds where it was previously crashing.
> Hadoop 3 missing fix for HDFS-5169
> ----------------------------------
>
> Key: HDFS-12714
> URL: https://issues.apache.org/jira/browse/HDFS-12714
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: native
> Affects Versions: 3.0.0-alpha1, 3.0.0-beta1, 3.0.0-alpha2, 3.0.0-alpha4,
> 3.0.0-alpha3
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
> Attachments: HDFS-12714.001.patch
>
>
> HDFS-5169 is a fix for a null pointer dereference in translateZCRException.
> This line in hdfs.c:
> ret = printExceptionAndFree(env, jthr, PRINT_EXC_ALL, "hadoopZeroCopyRead:
> ZeroCopyCursor#read failed");
> should be:
> ret = printExceptionAndFree(env, exc, PRINT_EXC_ALL, "hadoopZeroCopyRead:
> ZeroCopyCursor#read failed");
> Plainly, translateZCRException should print the exception (exc) passed in to
> the function rather than the uninitialized local jthr.
> The fix for HDFS-5169 (part of HDFS-4949) exists on hadoop 2.* branches, but
> it is missing on hadoop 3 branches including trunk.
> Hadoop 2.8:
> https://github.com/apache/hadoop/blob/branch-2.8/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c#L2514
> Hadoop 3.0:
> https://github.com/apache/hadoop/blob/branch-3.0/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c#L2691
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
