[ 
https://issues.apache.org/jira/browse/HDFS-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236497#comment-16236497
 ] 

Xiaoyu Yao commented on HDFS-12756:
-----------------------------------

Thanks [~anu] for the patch. It looks good to me overall. I just have one 
question:

DatanodeContainerProtocol.proto
Is there a reason that we make the datanodeID optional here but make datanodeID 
required for StorageContainerDatanodeProtocol.proto? Should we enforce that 
consistently?

> Ozone: Add datanodeID to heartbeat responses and container protocol
> -------------------------------------------------------------------
>
>                 Key: HDFS-12756
>                 URL: https://issues.apache.org/jira/browse/HDFS-12756
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-12756-HDFS-7240.001.patch
>
>
> if we have datanode ID in the HBs responses and commands send to datanode, we 
> will be able to do additional sanity checking on datanode before executing 
> the command. This is also very helpful in creating a MiniOzoneCluster with 
> 1000s of simulated nodes. This is needed for scale based unit tests of SCM.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to