[
https://issues.apache.org/jira/browse/HDFS-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237063#comment-16237063
]
Jiandan Yang commented on HDFS-12754:
--------------------------------------
Hi, [~kshukla], thanks for you patch. This patch could resolve dead lock, but I
have two comments about your patch:
1. DFSOutputStream#clientClosed can be removed, I think it's duplicated with
DFSOutputStream#closed.
2. When LeaseRenewer#run(int) catch SocketTimeoutException and run the follow
code after clean LeaseRenewer#dfsclients, dfsclient may create file and add a
new one to the LeaseRenewer#dfsclients
{code:java}
for (DFSClient dfsClient : dfsclientsCopy) {
dfsClient.closeAllFilesBeingWritten(true);
}
{code}
> Lease renewal can hit a deadlock
> ---------------------------------
>
> Key: HDFS-12754
> URL: https://issues.apache.org/jira/browse/HDFS-12754
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Kuhu Shukla
> Assignee: Kuhu Shukla
> Priority: Major
> Attachments: HDFS-12754.001.patch
>
>
> The Client and the renewer can hit a deadlock during close operation since
> closeFile() reaches back to the DFSClient#removeFileBeingWritten. This is
> possible if the client class close when the renewer is renewing a lease.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
