[
https://issues.apache.org/jira/browse/HDFS-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241219#comment-16241219
]
Íñigo Goiri commented on HDFS-12671:
------------------------------------
According to the FindBugs, the {{createImage}} can leave a stream open.
Not sure if this should be done in this JIRA though.
A small nit in the patch, at the end, it does:
{code}
assertTrue(dnInfos[0].getDatanodeUuid().equals(
providedDatanode.getDatanodeUuid()));
{code}
I think we should use {{assertEquals()}} as it would provide the right
semantics.
> [READ] Test NameNode restarts when PROVIDED is configured
> ---------------------------------------------------------
>
> Key: HDFS-12671
> URL: https://issues.apache.org/jira/browse/HDFS-12671
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Virajith Jalaparti
> Attachments: HDFS-12671-HDFS-9806.001.patch,
> HDFS-12671-HDFS-9806.002.patch, HDFS-12671-HDFS-9806.003.patch
>
>
> Add test case to ensure namenode restarts can be handled with provided
> storage.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
