[
https://issues.apache.org/jira/browse/HDFS-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244543#comment-16244543
]
Nanda kumar commented on HDFS-12549:
------------------------------------
[~xyao], review comments are addressed in patch v004.
bq. have you consider using the new JDK8 DateTimeFormatter/ZonedDateTime for
the handling of ozone creation/modification timestamp?
Thanks for the suggestion, I have modified it accordingly.
bq. Please add some comments to it and the default values for
OZONE_REST_CLIENT_HTTP_CONNECTION_MAX and maybe some document also in
ozone-default.xml
Done
bq. there are other configurations of PoolingHttpClientConnectionManager that
we might want to expose via OzoneConfigKeys in addition to the MaxTotal, e.g.,
max per route
Apart from MaxTotal also added DefaultMaxPerRoute, please let me know if
anything else needs to be added.
bq. we don't need to instantiate a new data formatter here. The hard coded
format string can be replaced by OzoneConsts.OZONE_DATE_FORMAT.
Fixed
bq. should use the getShortUserName()
Fixed
bq. executeHttpRequest does not close the response, which causes leaking of the
response stream.
Since in {{createKey}} and {{getKey}} the {{HttpEntity}} has to be close only
when we close the stream, the responsibility of consuming response HttpEntity
is given to the caller. I have updated the javadoc to make it explicit to the
caller of {{executeHttpRequest}}
> Ozone: OzoneClient: Support for REST protocol
> ---------------------------------------------
>
> Key: HDFS-12549
> URL: https://issues.apache.org/jira/browse/HDFS-12549
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Attachments: HDFS-12549-HDFS-7240.000.patch,
> HDFS-12549-HDFS-7240.001.patch, HDFS-12549-HDFS-7240.002.patch,
> HDFS-12549-HDFS-7240.003.patch, HDFS-12549-HDFS-7240.004.patch
>
>
> Support for REST protocol in OzoneClient.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
