[
https://issues.apache.org/jira/browse/HDFS-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245206#comment-16245206
]
Chen Liang commented on HDFS-12758:
-----------------------------------
+1 on v00 patch. The failed tests are unrelated. I've committed to the feature
branch. Thanks [~bharatviswa] for the contribution!
> Ozone: Correcting assertEquals argument order in test cases
> -----------------------------------------------------------
>
> Key: HDFS-12758
> URL: https://issues.apache.org/jira/browse/HDFS-12758
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nanda kumar
> Assignee: Bharat Viswanadham
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-12758-HDFS-7240.00.patch
>
>
> In few test cases, the arguments to {{Assert.assertEquals}} is swapped. Below
> is the list of classes and test-cases where this has to be corrected.
> {noformat}
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/ksm/TestKeySpaceManager.java
> testChangeVolumeQuota - line: 187, 197 & 204
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/web/TestDistributedOzoneVolumes.java
> testCreateVolumes - line: 91
> testCreateVolumesWithQuota - line: 103
> testCreateVolumesWithInvalidQuota - line: 115
> testCreateVolumesWithInvalidUser - line: 129
> testCreateVolumesWithOutAdminRights - line: 144
> testCreateVolumesInLoop - line: 156
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/web/client/TestKeys.java
> runTestPutKey - line: 239 & 246
> runTestPutAndListKey - line: 428, 429, 451, 452, 458 & 459
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/transport/server/TestContainerServer.java
> testClientServerWithContainerDispatcher - line: 219
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/ContainerTestHelper.java
> verifyGetKey - line: 491
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerPersistence.java
> testUpdateContainer - line: 776, 778, 794, 796, 821 & 823
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/common/TestEndPoint.java
> testGetVersion - line: 122 & 124
> testRegister - line: 215
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/replication/TestContainerReplicationManager.java
> testDetectSingleContainerReplica - line: 168
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/scm/TestXceiverClientManager.java
> testCaching - line: 82, 91, 96 & 97
> testFreeByReference - line: 120, 130 & 137
> testFreeByEviction - line: 165, 170, 177 & 185
> hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/ozone/TestOzoneAcls.java
> testAclValues - line: 111, 112, 113, 116, 117, 118, 121, 122, 123, 126, 127,
> 128, 131, 132, 133, 136, 137 & 138
> hadoop-tools/hadoop-ozone/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileInterfaces.java
> testFileSystemInit - line: 102
> testOzFsReadWrite - line: 123
> testDirectory - line: 135, 138 & 139
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
