[ 
https://issues.apache.org/jira/browse/HDFS-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045735#comment-13045735
 ] 

Hadoop QA commented on HDFS-2040:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481763/hdfs-2040-2.patch
  against trunk revision 1133225.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/737//console

This message is automatically generated.

> Only build libhdfs if a flag is passed
> --------------------------------------
>
>                 Key: HDFS-2040
>                 URL: https://issues.apache.org/jira/browse/HDFS-2040
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.23.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: hdfs-2040-1.patch, hdfs-2040-2.patch
>
>
> In HDFS-2022 we made ant binary build libhdfs unconditionally, this is a pain 
> for users who now need to get the native toolchain working to create a 
> tarball to test a change, and inconsistent with common and MR (see 
> MAPREDUCE-2559) which only build native code if a flag is passed. Let's 
> revert to the previous behavior of requiring -Dlibhdfs be passed at build 
> time. We could also create a new ant target that doesn't build the native 
> code, however restoring the old behavior seems simplest.  
>   

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to