[ 
https://issues.apache.org/jira/browse/HDFS-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253062#comment-16253062
 ] 

Yiqun Lin commented on HDFS-12787:
----------------------------------

Thanks for the review and comments, [~xyao]!

bq. Line 215: in addition to the aggregrated metrics, can we expose the 
containerReportCache from both API and/or JSON/JMX for the per datanode 
container IO stats? That will be ..
Good idea. Done.
bq. Line 318-323: Should we remove the entry only when the node is moved to 
stale/dead in the NodeManager? Expire the entry with 2*container report 
interval may get the container stats remove...
Good suggestion. Addressed this. When node is moved from healthy to stale, we 
will  remove its container entry.

All the other comments have been addressed in the latest patch.
Attach the new patch. Please have a review when you get a chance.

> Ozone: SCM: Aggregate the metrics from all the container reports
> ----------------------------------------------------------------
>
>                 Key: HDFS-12787
>                 URL: https://issues.apache.org/jira/browse/HDFS-12787
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: metrics, ozone
>    Affects Versions: HDFS-7240
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-12787-HDFS-7240.001.patch, 
> HDFS-12787-HDFS-7240.002.patch, HDFS-12787-HDFS-7240.003.patch
>
>
> We should aggregate the metrics from all the reports of different datanodes 
> in addition to the last report. This way, we can get a global view of the 
> container I/Os over the ozone cluster. This is a follow up work of HDFS-11468.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to