[ 
https://issues.apache.org/jira/browse/HDFS-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254357#comment-16254357
 ] 

Chris Douglas commented on HDFS-12681:
--------------------------------------

bq. I am not sure if this assumption works for other places, but at least our 
MR jobs get broken here with NPE.
This seemed preferable to returning empty locations, which will be harder to 
debug. One of the reasons I wanted to get this in early was to check for 
compatibility downstream.

bq. Do we have a quick solution to fix this problem? Otherwise, we may need to 
consider to revert this (and may be HDFS-7878).
Please don't. I've had to chase reviewers for over a _year_ to get any changes 
into {{FileSystem}}. This compromise incorporates others' preferences and 
concerns after months of negotiation.

bq. I also notice this belongs to incompatible change - any reason that not get 
in 3.0 but instead go to 3.1 besides the time window of 3.0 release?
No.

> Fold HdfsLocatedFileStatus into HdfsFileStatus
> ----------------------------------------------
>
>                 Key: HDFS-12681
>                 URL: https://issues.apache.org/jira/browse/HDFS-12681
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Minor
>             Fix For: 3.1.0
>
>         Attachments: HDFS-12681.00.patch, HDFS-12681.01.patch, 
> HDFS-12681.02.patch, HDFS-12681.03.patch, HDFS-12681.04.patch, 
> HDFS-12681.05.patch, HDFS-12681.06.patch, HDFS-12681.07.patch, 
> HDFS-12681.08.patch, HDFS-12681.09.patch, HDFS-12681.10.patch
>
>
> {{HdfsLocatedFileStatus}} is a subtype of {{HdfsFileStatus}}, but not of 
> {{LocatedFileStatus}}. Conversion requires copying common fields and shedding 
> unknown data. It would be cleaner and sufficient for {{HdfsFileStatus}} to 
> extend {{LocatedFileStatus}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to