[ 
https://issues.apache.org/jira/browse/HDFS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254707#comment-16254707
 ] 

Yongjun Zhang commented on HDFS-12730:
--------------------------------------

Hi [~manojg],

Thanks for the diligence on adding the tests. It looks good to me, one 
question: the test you added started with disabling the feature, then create 
snapshot. Can we also have a test that starts with the feature enabled, create 
snapshots, then disable the feature?


> Verify open files captured in the snapshots across config disable and enable
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-12730
>                 URL: https://issues.apache.org/jira/browse/HDFS-12730
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: hdfs
>    Affects Versions: 3.0.0
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>         Attachments: HDFS-12730.01.patch
>
>
> Open files captured in the snapshots have their meta data preserved based on 
> the config 
> _dfs.namenode.snapshot.capture.openfiles_ (refer HDFS-11402). During the 
> upgrade scenario or when the NameNode gets restarted with config turned on or 
> off,  the attributes of the open files captured in the snapshots are 
> influenced accordingly. Better to have a test case to verify open file 
> attributes across config turn on and off, and the current expected behavior 
> with HDFS-11402 so as to catch any regressions in the future.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to