[ https://issues.apache.org/jira/browse/HDFS-12794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260437#comment-16260437 ]
Mukul Kumar Singh commented on HDFS-12794: ------------------------------------------ Thanks for the updated patch [~shashikant], 1) ChunkGroupOutputStream : 297 please align the comments 2) ChunkGroupOutputStream: 423, I feel we should not create a new semaphore there, is there a case where the semaphore will be passed as null? 3) ContainerProtocolCalls.java:188-220, should the writeChunk Api use the the writeChunkAsync and then do a future on get ? 4) Please fix the checkstyle errors. 5) Unit test failure of org.apache.hadoop.ozone.TestOzoneConfigurationFields.testCompareConfigurationClassAgainstXml is related. Please have a look. > Ozone: Parallelize ChunkOutputSream Writes to container > ------------------------------------------------------- > > Key: HDFS-12794 > URL: https://issues.apache.org/jira/browse/HDFS-12794 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Affects Versions: HDFS-7240 > Reporter: Shashikant Banerjee > Assignee: Shashikant Banerjee > Fix For: HDFS-7240 > > Attachments: HDFS-12794-HDFS-7240.001.patch, > HDFS-12794-HDFS-7240.002.patch, HDFS-12794-HDFS-7240.003.patch > > > The chunkOutPutStream Write are sync in nature .Once one chunk of data gets > written, the next chunk write is blocked until the previous chunk is written > to the container. > The ChunkOutputWrite Stream writes should be made async and Close on the > OutputStream should ensure flushing of all dirty buffers to the container. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org