[
https://issues.apache.org/jira/browse/HDFS-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274764#comment-16274764
]
Xiao Chen edited comment on HDFS-12396 at 12/1/17 6:47 PM:
-----------------------------------------------------------
Thanks [~shahrs87] for fixing this and [~daryn] for reviews. Happy to see this
gets fixed.
The latest patches LGTM and is fairly separate, good work!
I'm +1 pending a minor typo:
{code}
[email protected]
[email protected]
[email protected]
+public class HdfsKMSUtil {
{code}
No Evolving.
I feel the unit test could be more thorough: currently it tests webhdfs
addDelegationTokens works. Ideally we'd want a higher level testing that the
(real) tokens can be used to successfully do HDFS operations. Can do this in
the other subtasks or a follow-on.
was (Author: xiaochen):
Thanks [~shahrs87] for fixing this and [~daryn] for reviews. Happy to see this
gets fixed.
The latest patches LGTM and is fairly separate, good work!
I'm +1 pending a minor typo:
{code}
[email protected]
[email protected]
[email protected]
+public class HdfsKMSUtil {
{code}
No Evolving.
I feel the unit test could be more thorough: currently it tests webhdfs
addDelegationTokens works. Ideally we'd want a higher level testing that these
tokens can be used to successfully do HDFS operations. Can do this in the other
subtasks or a follow-on.
> Webhdfs file system should get delegation token from kms provider.
> ------------------------------------------------------------------
>
> Key: HDFS-12396
> URL: https://issues.apache.org/jira/browse/HDFS-12396
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption, kms, webhdfs
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Attachments: HDFS-12396-branch-2.8.patch, HDFS-12396-branch-2.patch,
> HDFS-12396.001.patch, HDFS-12396.002.patch, HDFS-12396.003.patch,
> HDFS-12396.004.patch, HDFS-12396.005.patch, HDFS-12396.006.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
