[
https://issues.apache.org/jira/browse/HDFS-12591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275309#comment-16275309
]
Chris Douglas commented on HDFS-12591:
--------------------------------------
+1 overall, just a couple really minor nits:
* Instead of having a default, if the read path is unspecified then it should
probably fail to load
{noformat}
+ public static final String DFS_PROVIDED_BLOCK_MAP_DB_PATH_DEFAULT =
"/tmp/blocks.leveldb";
{noformat}
* {{createDB}} is marked as {{\@VisibleForTesting}} but it is private. It looks
like it could both be static and does not require synchronization
> [READ] Implement LevelDBFileRegionFormat
> ----------------------------------------
>
> Key: HDFS-12591
> URL: https://issues.apache.org/jira/browse/HDFS-12591
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Ewan Higgs
> Assignee: Ewan Higgs
> Priority: Minor
> Attachments: HDFS-12591-HDFS-9806.001.patch,
> HDFS-12591-HDFS-9806.002.patch, HDFS-12591-HDFS-9806.003.patch,
> HDFS-12591-HDFS-9806.004.patch, HDFS-12591-HDFS-9806.005.patch
>
>
> The existing work for HDFS-9806 uses an implementation of the {{FileRegion}}
> read from a csv file. This is good for testability and diagnostic purposes,
> but it is not very efficient for larger systems.
> There should be a version that is similar to the {{TextFileRegionFormat}}
> that instead uses LevelDB.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
