[
https://issues.apache.org/jira/browse/HDFS-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278549#comment-16278549
]
Mukul Kumar Singh commented on HDFS-12890:
------------------------------------------
Thanks for working on this [~shashikant], the patch looks good some comments
though.
1) getMaxOutstandingRequests should be moved to a common util class, How about
OzoneClientUtils.java
2) ozone-default.xml:1103, the comments should read more like "handled by the
Standalone as well as Ratis client"
3) XceiverClientHandler.java:35, we normally keep only the required libraries
by adding them in the expanded form.
4) XceiverClientHanlder.java:151-164, There are some unrelated changes in the
patch. Can you please revert them.
5) XceiverClientRatis.java, there is a unrelated change on line 155. Can you
please move the funtion to the next line ?
> XceiverClient should have upper bound on async requests
> -------------------------------------------------------
>
> Key: HDFS-12890
> URL: https://issues.apache.org/jira/browse/HDFS-12890
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: HDFS-7240
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12890-HDFS-7240.001.patch
>
>
> XceiverClient-ratis maintains upper bound on the no of outstanding async
> requests . XceiverClient
> should also impose an upper bound on the no of outstanding async requests
> received from client
> for write.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
