[
https://issues.apache.org/jira/browse/HDFS-12869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281096#comment-16281096
]
Anu Engineer commented on HDFS-12869:
-------------------------------------
[~nandakumar131] The patch looks very good and it will certainly make the user
experience of ozone API much better. Thank you getting this done. Few comments
# Should we file a JIRA for integrating this into REST protocol?
# {{ // TODO: REST servers (datanode) details to be added later.}} I know that
we have a {{queryNodes}} function in SCM and we can call that easily. So file a
JIRA for this also?
# {code}
message ServiceInfo {
required NodeType nodeType = 1;
required string hostname = 2;
optional uint32 rpcPort = 3;
optional uint32 httpPort = 4;
optional uint32 httpsPort = 5;
}
{code} I was wondering if we should make this message into 2 seperate messages.
We could have different ports ( or support sharing ports in datanodes). For
example, Standalone port and Ratis port.
Would it make sense to do something like this(just a quick example, not thought
through well)
{code}
message RpcPorts{
enum PortTypes {
HTTP,
StandAlone,
Ratis};
required PortTypes portType = 1;
required int port = 2;
}
message ServiceInfo {
required NodeType nodeType = 1;
required string hostname = 2;
repeated RpcPorts rpcPorts = 3;
}
{code}
This way it is easy to expand if we have to add or remove ports.
> Ozone: Service Discovery: RPC endpoint in KSM for getServiceList
> ----------------------------------------------------------------
>
> Key: HDFS-12869
> URL: https://issues.apache.org/jira/browse/HDFS-12869
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Attachments: HDFS-12869-HDFS-7240.000.patch
>
>
> A new RPC call to be added to KSM which will return the list of Services that
> are there in Ozone cluster, this will be used by OzoneClient for establishing
> the connection.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
