[ 
https://issues.apache.org/jira/browse/HDFS-12882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated HDFS-12882:
---------------------------------
    Attachment: HDFS-12882.03.patch

This adds a separate flag to {{getFileInfo}} that (eventually) controls whether 
{{FSDirStatAndListingOp::createFileStatus}} also generates block tokens for its 
{{LocatedBlocks}}. While a single flag would be sufficient for this issue, if 
one implemented {{getLocatedFileStatus}} then we'd need a similar flag. This 
also allows for correct metrics/audit, since this is an {{open}} call only if 
the client requested block tokens. If one does not request locations, then 
{{needBlockToken}} has no effect.

Alternatively, we could follow the pattern for {{getFileLinkInfo}}, and add 
{{ClientProtocol::getLocatedFileInfo}} that requests a 
{{HdfsLocatedFileStatus}} and only includes the block token flag. Internally 
(as with {{getFileLinkInfo}}) the changes are basically the same. Fewer, 
existing calls to {{getFileInfo}} (particularly in tests) would require updates.

v03 also fixes related unit test failures, checkstyle, and findbugs 
serialization warnings.

> Support full open(PathHandle) contract in HDFS
> ----------------------------------------------
>
>                 Key: HDFS-12882
>                 URL: https://issues.apache.org/jira/browse/HDFS-12882
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>         Attachments: HDFS-12882.00.patch, HDFS-12882.00.salient.txt, 
> HDFS-12882.01.patch, HDFS-12882.02.patch, HDFS-12882.03.patch
>
>
> HDFS-7878 added support for {{open(PathHandle)}}, but it only partially 
> implemented the semantics specified in the contract (i.e., open-by-inodeID). 
> HDFS should implement all permutations of the default options for 
> {{PathHandle}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to