[
https://issues.apache.org/jira/browse/HDFS-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282924#comment-16282924
]
Íñigo Goiri commented on HDFS-12893:
------------------------------------
I like this better.
For this:
{code}
if (storage.getStorageType() == StorageType.PROVIDED) {
storage = new DatanodeStorageInfo(node, storage.getStorageID(),
storage.getStorageType(), storage.getState());
}
{code}
You are pretty much just copying the storage.
Should we have a DatanodeProvidedInfo which just gets:
{code}
public class DatanodeProvidedInfo extends DatanodeStorageInfo {
public DatanodeProvidedInfo (node, storage) {
super(node, storage.getStorageID(), StorageType.PROVIDED,
storage.getState());
}
}
{code}
This may allow adding a couple more overrides.
> [READ] Support replication of Provided blocks with non-default topologies.
> --------------------------------------------------------------------------
>
> Key: HDFS-12893
> URL: https://issues.apache.org/jira/browse/HDFS-12893
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Virajith Jalaparti
> Assignee: Virajith Jalaparti
> Attachments: HDFS-12893-HDFS-9806.001.patch,
> HDFS-12893-HDFS-9806.002.patch, HDFS-12893-HDFS-9806.003.patch
>
>
> {{chooseSourceDatanodes}} returns the {{ProvidedDatanodeDescriptor}} as the
> source of Provided blocks. As this isn't a physical datanode and doesn't
> exist the topology, {{ReplicationWork.chooseTargets}} might fail depending on
> the chosen {{BlockPlacementPolicy}} implementation. This JIRA aims to fix
> this issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
