[
https://issues.apache.org/jira/browse/HDFS-12000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284078#comment-16284078
]
Xiaoyu Yao commented on HDFS-12000:
-----------------------------------
Thanks [~vagarychen] for the update. The patch looks good to me overall. Here
are a few comments:
ChunkGroupInputStream.java
Line 172: Can you briefly describe the plan to handle multiple version of the
blocks later with the following API.
{{keyInfo.getLatestVersionLocations().getBlocksLatestVersionOnly()}}.
I think it will work when we only have one version, i.e., latest version.
Correct me if I'm wrong, say we have K1 (B1V1, B2V2), with
getBlocksLatestVersionOnly, are we going to get B2V2 instead of (B1V1, B2V2)?
Line 173: NIT: more comment does not valid any more
KeySpaceManagerProtocol.proto
Line 268: should this openVersion as part of the request so that the client can
request open certain version? It is ok to
assume open the latest version for now. Maybe add a TODO for next JIRA on this
feature.
KsyKeyLocationInfo.java
Line 111: Is there a reason why the KsyKeyLocationInfo#Builder does not support
setCreateVersion? Do we expect it to be set directly on the KsyKeyLocationInfo
afterwards?
KsmKeyInfo.java
Line 22: NIT: unused imports
Line 58: if the version starts from 0, the special handling for
currentVersion==-1 is not needed. Can you confirm?
We could wrap this check into a util method for reuse.
OpenKeySession.java
Line 30: can the open version be committed without close, something like hsync
to populate the write without closing file.
> Ozone: Container : Add key versioning support-1
> -----------------------------------------------
>
> Key: HDFS-12000
> URL: https://issues.apache.org/jira/browse/HDFS-12000
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Chen Liang
> Labels: OzonePostMerge
> Attachments: HDFS-12000-HDFS-7240.001.patch,
> HDFS-12000-HDFS-7240.002.patch, HDFS-12000-HDFS-7240.003.patch,
> HDFS-12000-HDFS-7240.004.patch, HDFS-12000-HDFS-7240.005.patch,
> HDFS-12000-HDFS-7240.007.patch, HDFS-12000-HDFS-7240.008.patch,
> OzoneVersion.001.pdf
>
>
> The rest interface of ozone supports versioning of keys. This support comes
> from the containers and how chunks are managed to support this feature. This
> JIRA tracks that feature. Will post a detailed design doc so that we can talk
> about this feature.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
