[
https://issues.apache.org/jira/browse/HDFS-12626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284415#comment-16284415
]
Xiaoyu Yao commented on HDFS-12626:
-----------------------------------
Thanks [~vagarychen] for working on this. The patch looks pretty good to me. I
just have few minor comments:
OzoneConfigKeys.java
Line 139: suggest have two separate keys, one for the service check interval
for the periodical background thread.
ozone.open.key.deleting.service.interval.seconds=>
ozone.open.key.cleanup.service.interval.seconds
The other for the open key expire/stale threshold that will be used in
KSMMetadataManagerImpl.java and document them separately
ozone.open.key.expire.threshold.seconds
KeyManager.java
Line 154: NIT: getHangingOpenKeys-> getExpiredOpenKeys
Line 164: NIT: deleteExpriredOpenKey
KeyManagerImpl.java
Line 201: Do we update the keyInfo with the modification time when the block is
written to the container as well?
OpenKeyCleanupService.java
Line 81-88: some of the info logs can be changed into debug log.
TestKeySpaceManager.java
Line 1094-1095: can we wrap the Outputstream with try/final to ensure it is
closed.
> Ozone : delete open key entries that will no longer be closed
> -------------------------------------------------------------
>
> Key: HDFS-12626
> URL: https://issues.apache.org/jira/browse/HDFS-12626
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
> Attachments: HDFS-12626-HDFS-7240.001.patch,
> HDFS-12626-HDFS-7240.002.patch, HDFS-12626-HDFS-7240.003.patch,
> HDFS-12626-HDFS-7240.004.patch
>
>
> HDFS-12543 introduced the notion of "open key" where when a key is opened, an
> open key entry gets persisted, only after client calls a close will this
> entry be made visible. One issue is that if the client does not call close
> (e.g. failed), then that open key entry will never be deleted from meta data.
> This JIRA tracks this issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
