[ 
https://issues.apache.org/jira/browse/HDFS-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eli Collins reassigned HDFS-2055:
---------------------------------

    Assignee: Travis Crawford

Travis - thanks for contributing!

Patch looks good. Minor things..

You'll need to generate the diff using the git --no-prefix option.

Please add a test to src/c++/libhdfs/hdfs_test.c. Unfortunately the libhdfs 
test is currently broken on trunk (HDFS-2063) but it works on branch-0.20 so 
you can try there (arg, sorry). The command to run the libhdfs test is {{ant 
-Dcompile.c++=true -Dlibhdfs=true compile test}}.  Have you done any other 
testing?

Nit: the @param/return javadoc comments should start w lowercase and not end in 
a period. Also good to indicate that errno is set accordingly.

> Add hflush support to libhdfs
> -----------------------------
>
>                 Key: HDFS-2055
>                 URL: https://issues.apache.org/jira/browse/HDFS-2055
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: libhdfs
>            Reporter: Travis Crawford
>            Assignee: Travis Crawford
>         Attachments: HDFS-2055.patch
>
>
> libhdfs would be improved by adding support for hflush.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to