[ 
https://issues.apache.org/jira/browse/HDFS-12818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erik Krogen updated HDFS-12818:
-------------------------------
    Attachment: HDFS-12818.008.patch

Thanks for looking [~shv], actually the {{MiniDFSCluster.Builder}} is setting 
the value if we do not specify it explicitly:
{code}
    public Builder(Configuration conf) {
      this.conf = conf;
      this.storagesPerDatanode =
          FsDatasetTestUtils.Factory.getFactory(conf).getDefaultNumOfDataDirs();
    }
{code}
However I realized that this Factory configurability means I can create a 
{{FsDatasetTestUtils}} for {{SimulatedFSDataset}} which has a default dir count 
of 1. I tried this approach and it works well and it much cleaner, isolating 
changes to {{SimulatedFSDataset}}. Thanks for encouraging this better approach!

Attaching v008 patch.

> Support multiple storages in DataNodeCluster / SimulatedFSDataset
> -----------------------------------------------------------------
>
>                 Key: HDFS-12818
>                 URL: https://issues.apache.org/jira/browse/HDFS-12818
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode, test
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Minor
>         Attachments: HDFS-12818.000.patch, HDFS-12818.001.patch, 
> HDFS-12818.002.patch, HDFS-12818.003.patch, HDFS-12818.004.patch, 
> HDFS-12818.005.patch, HDFS-12818.006.patch, HDFS-12818.007.patch, 
> HDFS-12818.008.patch
>
>
> Currently {{SimulatedFSDataset}} (and thus, {{DataNodeCluster}} with 
> {{-simulated}}) only supports a single storage per {{DataNode}}. Given that 
> the number of storages can have important implications on the performance of 
> block report processing, it would be useful for these classes to support a 
> multiple storage configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to