[ 
https://issues.apache.org/jira/browse/HDFS-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294739#comment-16294739
 ] 

Mukul Kumar Singh commented on HDFS-12890:
------------------------------------------

Thanks for the latest patch [~shashikant], the latest patch looks good to me. 
some very minor comments. Rest looks good to me.

1) XceiverClient.java: Can you please provide a comment here, that we need to 
unwrap the exception to fetch the real reason for failure.

2) XceiverClientHandler.java:35, this import is unused, please remove.

3) XceiverClientHandler.java:114-118, should we use an iterator here?

> Ozone: XceiverClient should have upper bound on async requests
> --------------------------------------------------------------
>
>                 Key: HDFS-12890
>                 URL: https://issues.apache.org/jira/browse/HDFS-12890
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: HDFS-7240
>    Affects Versions: HDFS-7240
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12890-HDFS-7240.001.patch, 
> HDFS-12890-HDFS-7240.002.patch, HDFS-12890-HDFS-7240.003.patch, 
> HDFS-12890-HDFS-7240.004.patch
>
>
> XceiverClient-ratis maintains upper bound on the no of outstanding async 
> requests . XceiverClient
> should also impose an upper bound on the no of outstanding async requests 
> received from client
> for write.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to