[ 
https://issues.apache.org/jira/browse/HDFS-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295492#comment-16295492
 ] 

Íñigo Goiri commented on HDFS-12937:
------------------------------------

[^HDFS-12937.001.patch] looks good.
Not sure if it makes sense to do the cleaning of the stdout on a @Before or 
@After method.
Other than that, the new unit tests cover {{add}}, {{ls}}, and {{rm}} pretty 
exhaustively and they pass for QA.
+1

> RBF: Add more unit tests for router admin commands
> --------------------------------------------------
>
>                 Key: HDFS-12937
>                 URL: https://issues.apache.org/jira/browse/HDFS-12937
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-12937.001.patch
>
>
> Adding more unit tests to ensure that router admin commands works well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to