[ https://issues.apache.org/jira/browse/HDFS-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047832#comment-13047832 ]
Hadoop QA commented on HDFS-2066: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482128/h2066_20110610.patch against trunk revision 1134492. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 30 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/772//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/772//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/772//console This message is automatically generated. > Create a package and individual class files for DataTransferProtocol > -------------------------------------------------------------------- > > Key: HDFS-2066 > URL: https://issues.apache.org/jira/browse/HDFS-2066 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: data-node, hdfs client, name-node > Affects Versions: 0.23.0 > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Attachments: h2066_20110610.patch > > > {{DataTransferProtocol}} contains quite a few classes. It is better to > create a package and put the classes into individual files. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira