[
https://issues.apache.org/jira/browse/HDFS-12792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297765#comment-16297765
]
Wei Yan commented on HDFS-12792:
--------------------------------
The patch LGTM.
Some quick comments.
1. The following line can be removed.
{code:title=RouterHDFSContract.java}
public static final String CONTRACT_HDFS_XML = "contract/hdfs.xml";
{code}
2. Do you want to also add TestRouterHDFSContractGetFileStatus and
TestRouterHDFSContractSeek here?
3. No sure whether we should rename RouterDFSCluster to MiniRouterDFSCluster?
Is it any chance that we may need this name "RouterDFSCluster" in src/main in
the future?
> RBF: Test Router-based federation using HDFSContract
> ----------------------------------------------------
>
> Key: HDFS-12792
> URL: https://issues.apache.org/jira/browse/HDFS-12792
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Attachments: HDFS-12615.000.patch
>
>
> Router-based federation should support HDFSContract.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
