[ 
https://issues.apache.org/jira/browse/HDFS-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298970#comment-16298970
 ] 

Chen Liang commented on HDFS-12751:
-----------------------------------

Thanks [~nandakumar131] for the comment!

bq. 1. Getting all the containers from ContainerStateManager for updating 
allocated bytes.

Thanks for point this out, especially the link the JIRAs. Then let's this 
revisit this when HDFS-12522 is done, For now I think this should be fine as 
this should affect the time it takes to shut down SCM. I will follow up JIRAs 
later.

bq. 2. Exposing setter method for allocated bytes - setAllocatedBytes

Thanks for bringing up this point. I wonder though, is there a code path where 
SCM will read and rely on {{ContainerInfo}} instance from client? I was under 
impression that client only reads ContaienrInfo, but whatever the client does 
with this object will not be taken by the server side.



> Ozone: SCM: update container allocated size to container db for all the open 
> containers in ContainerStateManager#close
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12751
>                 URL: https://issues.apache.org/jira/browse/HDFS-12751
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nanda kumar
>            Assignee: Chen Liang
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12751-HDFS-7240.001.patch, 
> HDFS-12751-HDFS-7240.002.patch
>
>
> Container allocated size is maintained in memory by 
> {{ContainerStateManager}}, this has to be updated in container db when we 
> shutdown SCM. {{ContainerStateManager#close}} will be called during SCM 
> shutdown, so updating allocated size for all the open containers should be 
> done here.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to