[ 
https://issues.apache.org/jira/browse/HDFS-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300466#comment-16300466
 ] 

Chen Liang commented on HDFS-12951:
-----------------------------------

Thanks [~msingh] for the catch, the failed tests and findbug warnings are 
unrelated. +1 on v001 patch, I've committed to trunk. Thanks for the 
contribution.

> Incorrect javadoc in SaslDataTransferServer.java#receive 
> ---------------------------------------------------------
>
>                 Key: HDFS-12951
>                 URL: https://issues.apache.org/jira/browse/HDFS-12951
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: encryption
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>             Fix For: 3.1.0
>
>         Attachments: HDFS-12951.001.patch
>
>
> The javadoc for the receive incorrectly states "int" in the 4th parameter. 
> This should be corrected to remove the int.
> {code}
>   /**
>    * Receives SASL negotiation from a peer on behalf of a server.
>    *
>    * @param peer connection peer
>    * @param underlyingOut connection output stream
>    * @param underlyingIn connection input stream
>    * @param int xferPort data transfer port of DataNode accepting connection
>    * @param datanodeId ID of DataNode accepting connection
>    * @return new pair of streams, wrapped after SASL negotiation
>    * @throws IOException for any error
>    */
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to