[
https://issues.apache.org/jira/browse/HDFS-11847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301802#comment-16301802
]
Xiao Chen commented on HDFS-11847:
----------------------------------
Thanks Manoj for revving and the comments!
Looks good overall. Some additional comments:
- I'm okay for splitting to another jira about the DN and type changes. Please
create the jira and add a comment in {{FSN#listOpenFiles}} to point to that.
Looks like for the new stuff we don't need to change APIs, which is great.
- Sorry I wasn't clear in the earlier comment #1. Our [compat
policy|http://hadoop.apache.org/docs/r3.0.0/hadoop-project-dist/hadoop-common/Compatibility.html]
has different aspects. HDFS-10480 is in 2.9.0 and 2.8.3, so I think we need to
keep the old APIs for API and wire compat, and add the new one. (e.g.
HDFSAdmin.java is public evolving, DFS.java is LimitedPrivate). [~andrew.wang]
am I correct?
- We should respect {{maxListOpenFilesResponses}} in
{{FSN#getFilesBlockingDecom}}, to make the batchedlist indeed batched. :)
- Adding an extra tab to the middle of CLI output format is usually frowned
upon by admins - imagine there's a script that parses the output with a \t
delimiter.
- {{HDFSCommands.md}} has an unnecessary change in the first line
{{+<U+FEFF><!---}}
> Enhance dfsadmin listOpenFiles command to list files blocking datanode
> decommissioning
> --------------------------------------------------------------------------------------
>
> Key: HDFS-11847
> URL: https://issues.apache.org/jira/browse/HDFS-11847
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.0.0-alpha1
> Reporter: Manoj Govindassamy
> Assignee: Manoj Govindassamy
> Attachments: HDFS-11847.01.patch, HDFS-11847.02.patch,
> HDFS-11847.03.patch, HDFS-11847.04.patch
>
>
> HDFS-10480 adds {{listOpenFiles}} option is to {{dfsadmin}} command to list
> all the open files in the system.
> Additionally, it would be very useful to only list open files that are
> blocking the DataNode decommissioning. With thousand+ node clusters, where
> there might be machines added and removed regularly for maintenance, any
> option to monitor and debug decommissioning status is very helpful. Proposal
> here is to add suboptions to {{listOpenFiles}} for the above case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
