[ https://issues.apache.org/jira/browse/HDFS-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302840#comment-16302840 ]
Nanda kumar commented on HDFS-12958: ------------------------------------ Thanks [~vagarychen] for filing and working on this jira. +1, the change looks good to me. Test failures and findbugs warning are not related, I will commit this shortly. > Ozone: remove setAllocatedBytes method in ContainerInfo > ------------------------------------------------------- > > Key: HDFS-12958 > URL: https://issues.apache.org/jira/browse/HDFS-12958 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Chen Liang > Assignee: Chen Liang > Priority: Minor > Attachments: HDFS-12958-HDFS-7240.001.patch > > > We may want to remove {{setAllocatedBytes}} method from {{ContainerInfo}} and > we keep all fields of {{ContainerInfo}} immutable, such that client won't > accidentally change {{ContainerInfo}} and rely on the changed instance. > An alternative of having {{setAllocatedBytes}} is to always create a new > {{ContainerInfo}} instance whenever it needs to be changed. > This is based on [this > comment|https://issues.apache.org/jira/browse/HDFS-12751?focusedCommentId=16299750&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16299750] > from HDFS-12751. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org