[ 
https://issues.apache.org/jira/browse/HDFS-12871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311950#comment-16311950
 ] 

Xiaoyu Yao commented on HDFS-12871:
-----------------------------------

Thanks [~nandakumar131] for reporting the issue and posting the patch. It looks 
good to me. I just have two questions:

KeySpaceManager.java

Line 877-880: should we  return HTTPS port only if HTTPS is enabled by Netty 
HTTP server? i.e., infoSecurePort is set with a valid value by DN?

For large cluster with thousands of DNs, do we still want to add all of them to 
the getServiceList servlet result? Could this hit the max size of HTTP response 
header size (e.g., 8K) easily?


> Ozone: Service Discovery: Adding REST server details in ServiceList
> -------------------------------------------------------------------
>
>                 Key: HDFS-12871
>                 URL: https://issues.apache.org/jira/browse/HDFS-12871
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nanda kumar
>            Assignee: Nanda kumar
>         Attachments: HDFS-12871-HDFS-7240.000.patch
>
>
> The datanode (REST server) details has to be added as part of 
> ServiceDiscovery {{getServiceList}} call.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to