[
https://issues.apache.org/jira/browse/HDFS-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312982#comment-16312982
]
Shashikant Banerjee edited comment on HDFS-12966 at 1/5/18 11:32 AM:
---------------------------------------------------------------------
Thanks [~xyao], for the review comments.
{code}
Ozone.proto
Can you elaborate on the reason to change owner from a enum (protobuf) to any
string? I can think of this is needed if we need support more than one Cblock,
KSM or NN servers to share the same SCM cluster?
{code}
Yes, this is needed if we need support more than one Cblock, KSM or NN servers
to share the same SCM cluster. Idea here was to set the owner name properly ,so
that later on ,we can explicitly list the containers pertaining to specific
ksm/cblock instance and selectively them as well in case we want to delete all
the data specfic to any ksm/cblock instance. This will be useful while
implementing ksm --expunge command(HDFS-12742).
{code}
CBlockManager.java
Line 127: The cblockID should be a const (initialized and persisted once per
cblock server) to represent containers owned as cblock instead of random UUID
changed upon each cblock server restart.
{code}
Yes I do agree, Currently we don't have any mechanism to persist the cblock id
as we have for KSM. I think its better to harcode it as "CBLOCK" for time being
and fix it when we implement the cblock id generation code.
Patch v4 addresses the remaining comments. Please have a look.
was (Author: shashikant):
Thanks [~xyao], for the review comments.
{code}
Ozone.proto
Can you elaborate on the reason to change owner from a enum (protobuf) to any
string? I can think of this is needed if we need support more than one Cblock,
KSM or NN servers to share the same SCM cluster?
{code}
Yes, this is needed if we need support more than one Cblock, KSM or NN servers
to share the same SCM cluster. Idea here was to set the owner name properly ,so
that
later on ,we can explicitly list the containers pertaining to specific
ksm/cblock instance and selectively them as well in case we want to delete all
the data specfic to any ksm/cblock instance.
{code}
CBlockManager.java
Line 127: The cblockID should be a const (initialized and persisted once per
cblock server) to represent containers owned as cblock instead of random UUID
changed upon each cblock server restart.
{code}
Yes I do agree, Currently we don't have any mechanism to persist the cblock id
as we have for KSM. I think its better to harcode it as "CBLOCK" for time being
and fix it when we implement the cblock id generation code.
Patch v4 addresses the remaining comments. Please have a look.
> Ozone: owner name should be set properly when the container allocation happens
> ------------------------------------------------------------------------------
>
> Key: HDFS-12966
> URL: https://issues.apache.org/jira/browse/HDFS-12966
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: HDFS-7240
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12966-HDFS-7240.001.patch,
> HDFS-12966-HDFS-7240.002.patch, HDFS-12966-HDFS-7240.003.patch,
> HDFS-12966-HDFS-7240.004.patch
>
>
> Currently , while the container allocation happens, the owner name is
> hardcoded as "OZONE".
> It should be set to KSM instance id/ CBlock Manager instance Id from where
> the container creation call happens.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
