[
https://issues.apache.org/jira/browse/HDFS-12794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320887#comment-16320887
]
Xiaoyu Yao commented on HDFS-12794:
-----------------------------------
Thanks [~shashikant] for the update. The latest patch LGTM. Just few minor
issues below. Can you also manuual run the failed Jenkins test and confirm if
they are related to this patch. If not, please file JIRAs to fix them
separately.
OzoneConfigKeys.java
Line 110: can you define a default const for stream buffer size?
ChunkGroupOutputStream.java
Line 124: NIT: the java doc needs to be updated block size-> stream buffer size
Line 93/458: can you use the const from OzoneConfigKeys for max stream buffer
size?
Line 428: NIT: blockSize->streamBufferSize?
> Ozone: Parallelize ChunkOutputSream Writes to container
> -------------------------------------------------------
>
> Key: HDFS-12794
> URL: https://issues.apache.org/jira/browse/HDFS-12794
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12794-HDFS-7240.001.patch,
> HDFS-12794-HDFS-7240.002.patch, HDFS-12794-HDFS-7240.003.patch,
> HDFS-12794-HDFS-7240.004.patch, HDFS-12794-HDFS-7240.005.patch,
> HDFS-12794-HDFS-7240.006.patch, HDFS-12794-HDFS-7240.007.patch,
> HDFS-12794-HDFS-7240.008.patch
>
>
> The chunkOutPutStream Write are sync in nature .Once one chunk of data gets
> written, the next chunk write is blocked until the previous chunk is written
> to the container.
> The ChunkOutputWrite Stream writes should be made async and Close on the
> OutputStream should ensure flushing of all dirty buffers to the container.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
