[
https://issues.apache.org/jira/browse/HDFS-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327730#comment-16327730
]
Mukul Kumar Singh commented on HDFS-13017:
------------------------------------------
Thanks for the patch [~elek]. The patch looks really good. Some minor comments
1) Please import the entire class
"CBlockClientServerProtocolProtos.ListVolumesResponseProto" this will help in
better formatting of functions.
2) CblockTargetServer.java:113, is never used, should we remove this line ?
3) Checkstyle issues
4) As Chen suggested, can a test be added to this, we have have a simple test
to check for list volume after a volume is created.
> Block Storage: implement simple iscsi discovery in jscsi server
> ---------------------------------------------------------------
>
> Key: HDFS-13017
> URL: https://issues.apache.org/jira/browse/HDFS-13017
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Attachments: HDFS-13017-HDFS-7240.001.patch
>
>
> The current jscsi server doesn't support iscsi discovery.
> To use jscsi server as a kubernetes storage backend we need the discovery.
> jScsi supports it we need just override a method and add an additional call
> to the server protocl to get the list of the available cblocks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
