[
https://issues.apache.org/jira/browse/HDFS-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329613#comment-16329613
]
Rushabh S Shah edited comment on HDFS-12574 at 1/17/18 10:35 PM:
-----------------------------------------------------------------
Thanks [~daryn] for the review.
{quote}Only substantive comment is I think you can revert the changes in
NamenodeWebHdfsMethods#redirectURI. Instead of passing in a ResponseBuilder and
FileStatus just for the sole purpose of letting OPEN set a header, push the
logic up into the open call. That will also avoid introducing a new unnecessary
getFileInfo for creates.
{quote}
In the coming patches for supporting EZ for webhdfs create, append, I will use
the {{ResponseBuilder}} in {{redirectUri}}.
I have made the changes for doing getFileInfo just for {{Open, Append,
GETFILECHECKSUM}}.
{quote}Very trivial comment is instead of donotFollowRedirect, perhaps use
followRedirects to match the name of the HttpURLConnection method name. It's a
bit clumsy to read logic that negates a negative.
{quote}
Changed in the latest patch.
bq. Also, please add client tests for reading a reserved inode path in an EZ,
with and w/o the reserved raw prefix.
Today we don't support resolving of
{{/.reserved/raw/.reserved/.inodes/<inodeNum>}}.
So we can't read from EZ directory with {{/.reserved/.inodes}} using webhdfs.
Created HDFS-13029 for that.
was (Author: shahrs87):
Thanks [~daryn] for the review.
{quote}
Only substantive comment is I think you can revert the changes in
NamenodeWebHdfsMethods#redirectURI. Instead of passing in a ResponseBuilder
and FileStatus just for the sole purpose of letting OPEN set a header, push the
logic up into the open call. That will also avoid introducing a new
unnecessary getFileInfo for creates.
{quote}
In the coming patches for supporting EZ for webhdfs create, append, I will use
the {{ResponseBuilder}} in {{redirectUri}}.
I have made the changes for doing getFileInfo just for {{Open, Append,
GETFILECHECKSUM}}.
{quote}
Very trivial comment is instead of donotFollowRedirect, perhaps use
followRedirects to match the name of the HttpURLConnection method name. It's a
bit clumsy to read logic that negates a negative.
{quote}
Changed in the latest patch.
> Add CryptoInputStream to WebHdfsFileSystem read call.
> -----------------------------------------------------
>
> Key: HDFS-12574
> URL: https://issues.apache.org/jira/browse/HDFS-12574
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption, kms, webhdfs
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Priority: Major
> Attachments: HDFS-12574.001.patch, HDFS-12574.002.patch,
> HDFS-12574.003.patch, HDFS-12574.004.patch, HDFS-12574.005.patch,
> HDFS-12574.006.patch, HDFS-12574.007.patch, HDFS-12574.008.patch,
> HDFS-12574.009.patch, HDFS-12574.010.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
