[
https://issues.apache.org/jira/browse/HDFS-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331527#comment-16331527
]
Xiaoyu Yao commented on HDFS-12868:
-----------------------------------
[~nandakumar131] , thanks for the patch. It looks good to me overall. I just
have two minor suggestions.
RestClient.java
Line 180-197: use try/finally to ensure the resource is released properly upon
exception
Consider wrap the DN selection logic with an interface so that it can be used
for customization like locality, rack-awareness, etc.
> Ozone: Service Discovery API
> ----------------------------
>
> Key: HDFS-12868
> URL: https://issues.apache.org/jira/browse/HDFS-12868
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Attachments: HDFS-12868-HDFS-7240.000.patch
>
>
> Currently if a client wants to connect to Ozone cluster we need multiple
> properties to be configured in the client.
> For RPC based connection we need
> {{ozone.ksm.address}}
> {{ozone.scm.client.address}}
> and the ports if something other than default is configured.
> For REST based connection
> {{ozone.rest.servers}}
> and port if something other than default is configured.
> With the introduction of Service Discovery API the client should be able to
> discover all the configurations needed for the connection. Service discovery
> calls will be handled by KSM, at the client side, we only need to configure
> {{ozone.ksm.address}}. The client should first connect to KSM and get all the
> required configurations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
