[ 
https://issues.apache.org/jira/browse/HDFS-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331653#comment-16331653
 ] 

Yiqun Lin commented on HDFS-13028:
----------------------------------

Latest patch looks good to me. Only one minor comment: Would you use the 
parameters passing way to print log instead of useing "+"?
{code}
LOG.error("Stats for " + i + " don't match: " + combinedData[i] + "!=" + 
individualData[i]);
{code}
I'm +1 after this and feel free to commit, :).

> RBF: Fix spurious TestRouterRpc#testProxyGetStats
> -------------------------------------------------
>
>                 Key: HDFS-13028
>                 URL: https://issues.apache.org/jira/browse/HDFS-13028
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Minor
>              Labels: RBF
>         Attachments: HDFS-13028.000.patch, HDFS-13028.001.patch
>
>
> TestRouterRpc#testProxyGetStats is failing frequently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to