[
https://issues.apache.org/jira/browse/HDFS-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336749#comment-16336749
]
hu xiaodong commented on HDFS-12963:
------------------------------------
hello, [~ajisakaa],can you commit this? than you very much.
> error log level in ShortCircuitRegistry#removeShm
> -------------------------------------------------
>
> Key: HDFS-12963
> URL: https://issues.apache.org/jira/browse/HDFS-12963
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: hu xiaodong
> Assignee: hu xiaodong
> Priority: Minor
> Attachments: HDFS-12963.001.patch
>
>
> {code:title=org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.java|borderStyle=solid}
> public synchronized void removeShm(ShortCircuitShm shm) {
> if (LOG.isTraceEnabled()) {
> LOG.debug("removing shm " + shm); ------------------ I think here
> should be trace
> }
> // Stop tracking the shmId.
> RegisteredShm removedShm = segments.remove(shm.getShmId());
> Preconditions.checkState(removedShm == shm,
> "failed to remove " + shm.getShmId());
> // Stop tracking the slots.
> for (Iterator<Slot> iter = shm.slotIterator(); iter.hasNext(); ) {
> Slot slot = iter.next();
> boolean removed = slots.remove(slot.getBlockId(), slot);
> Preconditions.checkState(removed);
> slot.makeInvalid();
> }
> // De-allocate the memory map and close the shared file.
> shm.free();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
