[
https://issues.apache.org/jira/browse/HDFS-13058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338323#comment-16338323
]
Arpit Agarwal commented on HDFS-13058:
--------------------------------------
Looks good, one minor comment for coding style:
{code}
+ "qjournal://journal0\\:9900;journal1:9901/"+journalId);
{code}
There should be spaces before and after the {{+}} operator.
+1 otherwise, pending Jenkins.
> Fix dfs.namenode.shared.edits.dir in TestJournalNode
> ----------------------------------------------------
>
> Key: HDFS-13058
> URL: https://issues.apache.org/jira/browse/HDFS-13058
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDFS-13058.00.patch
>
>
> In TestJournalNode.java
> dfs.namenode.shared.edits.dir is set as below.
> conf.set(DFSConfigKeys.DFS_NAMENODE_SHARED_EDITS_DIR_KEY +".ns1" +".nn1",
> "qjournal://journalnode0:9900;journalnode1:9901");
>
> From HDFS documentaion:
> [https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/HDFSHighAvailabilityWithQJM.html]
> The URI should be of the form:
> {{qjournal://*host1:port1*;*host2:port2*;*host3:port3*/*journalId*}}.
>
> Found this, when I was working for another jira, as when parsing this
> dfs.namenode.shared.edits.dir property got an exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
