[ https://issues.apache.org/jira/browse/HDFS-12522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338379#comment-16338379 ]
Xiaoyu Yao commented on HDFS-12522: ----------------------------------- Thanks [~anu] for the update. The patch v2 looks pertty good to me. I just have two minor comments: SCMException.java: NIT: Line 117 unncessary change. BlockManagerImpl.java Line 270: the udpate of allocatedbytes looks good to me. I notice that we have a TODO in 421 to reclaim the deleted block space from container. Please ensure we have a open JIRA on this to fix this. ContainerMapping.java Line 408, # of parameter does not match the # of {} in the LOG.error statement. > Ozone: Remove the Priority Queues used in the Container State Manager > --------------------------------------------------------------------- > > Key: HDFS-12522 > URL: https://issues.apache.org/jira/browse/HDFS-12522 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Anu Engineer > Assignee: Anu Engineer > Priority: Major > Attachments: HDFS-12522-HDFS-7240.001.patch, > HDFS-12522-HDFS-7240.002.patch > > > During code review of HDFS-12387, it was suggested that we remove the > priority queues that was used in ContainerStateManager. This JIRA tracks that > issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org