[
https://issues.apache.org/jira/browse/HDFS-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338658#comment-16338658
]
Yiqun Lin edited comment on HDFS-13042 at 1/25/18 3:09 AM:
-----------------------------------------------------------
[~elgoiri], thanks for addressing the comments. Looks very good now, just one
comment:
{noformat}
<property>
+ <name>dfs.federation.router.heartbeat-state.interval</name>
+ <value>5000</value>
+ <description>
+ How often the Router should heartbeat its state into the State Store in
milliseconds.
+ </description>
+ </property>
{noformat}
Would you change default value to {{5s}}? Since this setting support time units
suffixes, there will be a warning log generated when we passing a non-suffix
value. In additional, we may document more that this setting supports multiple
time unit suffixes as {{dfs.federation.router.quota-cache.update.interval}}
described.
This comment also should be removed.
{noformat}
// Use same interval as the cache update service
{noformat}
+1 once addressed.
As I saw you have attached the follow-up patches, I will give my initial review
today.
was (Author: linyiqun):
[~elgoiri], thanks for addressing the comments. Looks very good now, just one
comment:
{noformat}
<property>
+ <name>dfs.federation.router.heartbeat-state.interval</name>
+ <value>5000</value>
+ <description>
+ How often the Router should heartbeat its state into the State Store in
milliseconds.
+ </description>
+ </property>
{noformat}
Would you change default value to {{5s}}? Since this setting support time units
suffixes, there will be a warning log generated when we passing a non-suffix
value. In additional, we may document more that this setting supports multiple
time unit suffixes as {{dfs.federation.router.quota-cache.update.interval}}
described. +1 once addressed.
As I saw you have attached the follow-up patches, I will give my initial review
today.
> RBF: Heartbeat Router State
> ---------------------------
>
> Key: HDFS-13042
> URL: https://issues.apache.org/jira/browse/HDFS-13042
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-13042.000.patch, HDFS-13042.001.patch,
> HDFS-13042.002.patch
>
>
> The Router should heartbeat its state to the State Store.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
