[
https://issues.apache.org/jira/browse/HDFS-13057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339659#comment-16339659
]
Uma Maheswara Rao G commented on HDFS-13057:
--------------------------------------------
Thank you [~rakeshr] for the patch.
Patch mostly look good, I have few minor comments though.
1.
{code:java}
+ if (childrenCount <= 0) {
+ service.addAllFileIdsToProcess(inodeId, new ArrayList<>(), true);
+ } else {
+ service.markScanCompletedForPath(inodeId);
+ }{code}
Could you add doc about about condition? May be a TODO to improve the condition
as well.
2.
{code:java}
+ // testMaxRetryForFailedBlock{code}
Can you remove this from TestExternalStoragePolicySatisfier
3. IsSatisfierRunningCommand: Probably usage should say, this is mainly tells
whether SPS running inside NN. I agree command itself self descriptive, it may
be worth clarifying in usage as well to be in sync.
4.
{code:java}
+ Administrator can dynamically change the StoragePolicySatisfier mode by using
reconfiguration option.
Dynamic enabling/disabling option can be achieved in the following way.{code}
I feel we should say change modes, instead of enable/disable
5. internal service to NN —> internal service in NN
6.
{code:java}
if (childrenCount <= 0) {
+ service.addAllFileIdsToProcess(inodeId, new ArrayList<>(), true);
+ }{code}
Can we put log here saying empty directory?
> [SPS]: Revisit configurations to make SPS service modes internal/external/none
> ------------------------------------------------------------------------------
>
> Key: HDFS-13057
> URL: https://issues.apache.org/jira/browse/HDFS-13057
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Priority: Blocker
> Attachments: HDFS-13057-HDFS-10285-00.patch,
> HDFS-13057-HDFS-10285-01.patch
>
>
> This task is to revisit the configurations to make SPS service modes -
> {{internal/external/none}}
> - {{internal}} : represents SPS service will be running with NN
> - {{external}}: represents SPS service will be running outside NN
> - {{none}}: represents the SPS service is completely disabled and zero cost
> to the system.
> Proposed configuration {{dfs.storage.policy.satisfier.mode}} item in
> hdfs-site.xml file and value will be string. The mode can be changed via
> {{reconfig}} command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
