[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340704#comment-16340704
]
Yiqun Lin edited comment on HDFS-13043 at 1/26/18 8:27 AM:
-----------------------------------------------------------
Hi [~elgoiri], patch almost looks good to me.Seeing from the screenshot and
patch, just some initial review comments:
*FederationMetrics.java*
line306: This line can be simplified as {{LOG.error("Cannot get Routers JSON
from the State Store", e);}}
line325 and line329: I don't think it's appropriate to show the seconds time
since last contact time. For example, as screenshot showed, users won't know
how long 1213103 seconds ago meaning. For the mount table and membership, just
showing their last modified time will be good.
In addition, would you document the version meaning of mount table and
membership in definition? Users maybe confused for the mount table/membership
version meaning here when reading the codes.
*federationhealth.html*
line263, 264, 275, and 276: Can we update these names once we decided to show
the last modified time of these info?
*TestFederationMetrics.java*
line221: We need add one new line for checking the field {{buildVersion}}.
From the screenshot, I caught another one problem: Version info doesn't show
correctly.
It should be showed like {{3.1.0-SNAPSHOT from
2e5865606b7701ee79d0d297238ab58a07a9f61f by jenkins source checksum
a426dcb87c91dc70ad3343b1d819c478}} which I got from json string.
Revisiting the method {{FederationUtil#getBuildVersion}},
{noformat}
/**
* Fetch the compile timestamp for this jar.
*
* @return Date compiled.
*/
public static String getBuildVersion() {
return VersionInfo.getBuildVersion();
}
{noformat}
Actually we may need the info of {{VersionInfo.getVersion()}} instead of
builder version here. The latter contains version, revision, user and date. But
additional info is not needed to show in web UI.
was (Author: linyiqun):
Hi [~elgoiri], patch almost looks good to me.Seeing from the screenshot and
patch, just some initial review comments:
*FederationMetrics.java*
line306: This line can be simplified as {{LOG.error("Cannot get Routers JSON
from the State Store", e);}}
line325 and line329: I don't think it's appropriate to show the seconds time
since last contact time. For example, as screenshot showed, users won't know
how long 1213103 seconds ago meaning. For the mount table and membership, just
showing their last modified time will be good.
In addition, would you document the version meaning of mount table and
membership? Users maybe confused for the mount table/membership version meaning
here when reading the codes.
*federationhealth.html*
line263, 264, 275, and 276: Can we update these names once we decided to show
the last modified time of these info?
*TestFederationMetrics.java*
line221: We need add one new line for checking the field {{buildVersion}}.
From the screenshot, I caught another one problem: Version info doesn't show
correctly.
It should be showed like {{3.1.0-SNAPSHOT from
2e5865606b7701ee79d0d297238ab58a07a9f61f by jenkins source checksum
a426dcb87c91dc70ad3343b1d819c478}} which I got from json string.
Revisiting the method {{FederationUtil#getBuildVersion}},
{noformat}
/**
* Fetch the compile timestamp for this jar.
*
* @return Date compiled.
*/
public static String getBuildVersion() {
return VersionInfo.getBuildVersion();
}
{noformat}
Actually we may need the info of {{VersionInfo.getVersion()}} instead of
builder version here. The latter contains version, revision, user and date. But
additional info is not needed to show in web UI.
> RBF: Expose the state of the Routers in the federation
> ------------------------------------------------------
>
> Key: HDFS-13043
> URL: https://issues.apache.org/jira/browse/HDFS-13043
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-13043.000.patch, HDFS-13043.001.patch,
> router-info.png
>
>
> The Router should expose the state of the other Routers in the federation
> through a user UI.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
