[ 
https://issues.apache.org/jira/browse/HDFS-13062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341853#comment-16341853
 ] 

Hanisha Koneru commented on HDFS-13062:
---------------------------------------

Thanks [~bharatviswa] for working on this.
 # If my federated HA cluster has different set of JNs for different 
namespaces, then we should check that we should not add the dirs corresponding 
to another namespace in the JNs {{locaDir}}. For example, if we have the 
following config settings:
{code:java}
dfs.namenode.shared.edits.dir.ns1 = qjournal://jn1;jn2;jn3/ns1
dfs.namenode.shared.edits.dir.ns2 = qjournal://jn4;jn5;jn6/ns2
dfs.journalnode.edits.dir.ns1 = /disk1/jn
dfs.journalnode.edits.dir.ns2 = /disk2/jn
{code}
Here, we should not add journal dir {{/disk2/jn}} to the {{localDir}} of JNs 
{{jn1, jn2 and jn3}}. Or we should maintain a separate list of actual local 
dirs corresponding to the JN. For one, in {{JournalNode#getJournalStatus()}}, 
we used to not check localDir as it would have already been validated in 
{{validateAndCreateJournalDir()}}.
{code:java}
    // Also note that we do not need to check localDir here since
    // validateAndCreateJournalDir has been called before we register the
    // MXBean.
{code}
In the current code, the {{validateAndCreateJournalDir()}} would not perform 
any checks for the case of different journal dirs for different namespaces. 
Also, if {{/disk2/jn}} exists in {{jn1}}, then its status would also be 
returned by the \{{getJournalStatus()}} method. We should not display the 
status of dirs not belonging to the JN in its jmx.

 # 
{code:java}
      if(localDir.size() > 1) {
        DiskChecker.checkDir(logDir);
      }
{code}
We should keep the DiskChecker implementation same irrespective of how the 
journal dir has been configured.

> Provide support for JN to use separate journal disk per namespace
> -----------------------------------------------------------------
>
>                 Key: HDFS-13062
>                 URL: https://issues.apache.org/jira/browse/HDFS-13062
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>         Attachments: HDFS-13062.00.patch, HDFS-13062.01.patch
>
>
> In Federated HA setup, provide support for separate journal disk for each 
> namespace.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to