[ 
https://issues.apache.org/jira/browse/HDFS-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343683#comment-16343683
 ] 

Surendra Singh Lilhore commented on HDFS-13077:
-----------------------------------------------

Thanks [~rakeshr] for patch. I verified patch in secure cluster It is working 
fine.

One minor comment, I feel \{{dfs.storage.policy.satisfier.keytab.enabled}} 
property is not required.

{{SecurityUtil.login()}} will check internally if security is enable or not.
{code:java}
    if(! UserGroupInformation.isSecurityEnabled())
      return;{code}

> [SPS]: Fix review comments of external storage policy satisfier
> ---------------------------------------------------------------
>
>                 Key: HDFS-13077
>                 URL: https://issues.apache.org/jira/browse/HDFS-13077
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-10285
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>            Priority: Major
>         Attachments: HDFS-13077-HDFS-10285-00.patch
>
>
> This task is to address the following Uma's review comments:
>  - Implement login with external SPS keytab
>  - make SPS outstanding requests Q limit configurable. Configuration could be 
> {{dfs.storage.policy.satisfier.max.outstanding.paths}}
>  - fix checkstyle warnings



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to