[
https://issues.apache.org/jira/browse/HDFS-12942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344424#comment-16344424
]
Ajay Kumar edited comment on HDFS-12942 at 1/30/18 2:50 AM:
------------------------------------------------------------
[~virajith], Updated patch to address your comments with one minor change.
Instead of incrementing both dfs and number of blocks for volume new patch
increments only no of blocks(as is the case right now). I am investigating if
current code doesn't increment dfs used correctly but if that is the case it
will be different bug altogether. (will file another jira for it)
i.e {{volume.incrNumBlocks(bpid)}} instead of
{{volume.incDfsUsedAndNumBlocks(bpid, newReplicaInfo.getBytesOnDisk())}}
was (Author: ajayydv):
[~virajith], Updated patch to address your comments with one minor change.
Instead of incrementing both dfs and number of blocks for volume new patch
increments only no of blocks(as is the case right now). I am investigating if
current code doesn't increment dfs used correctly but if that is the case it
will be different bug altogether. (will file another jira for it)
{{volume.incrNumBlocks(bpid)}} {{volume.incDfsUsedAndNumBlocks(bpid,
newReplicaInfo.getBytesOnDisk())}}
> Synchronization issue in FSDataSetImpl#moveBlock
> ------------------------------------------------
>
> Key: HDFS-12942
> URL: https://issues.apache.org/jira/browse/HDFS-12942
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDFS-12942.001.patch, HDFS-12942.002.patch,
> HDFS-12942.003.patch, HDFS-12942.004.patch, HDFS-12942.005.patch,
> HDFS-12942.006.patch
>
>
> FSDataSetImpl#moveBlock works in following following 3 steps:
> # first creates a new replicaInfo object
> # calls finalizeReplica to finalize it.
> # Calls removeOldReplica to remove oldReplica.
> A client can potentially append to the old replica between step 1 and 2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
