[
https://issues.apache.org/jira/browse/HDFS-13062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345996#comment-16345996
]
Hanisha Koneru commented on HDFS-13062:
---------------------------------------
Thanks for updating the patch, [~bharatviswa].
* In {{setConf()}}, why are we getting the nameserviceIds from the config key
{{DFS_INTERNAL_NAMESERVICES_KEY}} before {{DFS_NAMESERVICES}}? IIUC from
HDFS-6376, which introduced the internal nameservices key, it is meant for
datanodes to distinguish between which nameservices to connect to. JournalNodes
should not be using this configuration to deduce the nameservice Ids. Please
correct me if I am wrong.
* In {{getLogDir}}:
** The if condition below should check that the {{dir}} path does not exist
in {{localDir}}. The {{dir.exists}} check is not sufficient to ensure that the
{{dir}} path has been validated by {{validateAndCreateJournalDir}}.
{code:java}
else if (!new File(dir.trim()).exists()){{code}
** The above check should be done irrespective of which config setting
{{dir}} is configured from.
** In {{getLogDir}}, we can reuse and optimize the File objects. {{new
File(dir.trim())}} is created multiple times with the same {{dir}} path.
{code} if (dir == null) {
dir = conf.get(DFSConfigKeys.DFS_JOURNALNODE_EDITS_DIR_KEY,
DFSConfigKeys.DFS_JOURNALNODE_EDITS_DIR_DEFAULT);
}
File journalDir = new File(dir.trim());
if (!localDir.contains(journalDir)) {
validateAndCreateJournalDir(journalDir);
....
}
{code}
> Provide support for JN to use separate journal disk per namespace
> -----------------------------------------------------------------
>
> Key: HDFS-13062
> URL: https://issues.apache.org/jira/browse/HDFS-13062
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDFS-13062.00.patch, HDFS-13062.01.patch,
> HDFS-13062.02.patch, HDFS-13062.03.patch, HDFS-13062.04.patch
>
>
> In Federated HA setup, provide support for separate journal disk for each
> namespace.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
