[ 
https://issues.apache.org/jira/browse/HDFS-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347408#comment-16347408
 ] 

Bharat Viswanadham edited comment on HDFS-13073 at 1/31/18 7:08 PM:
--------------------------------------------------------------------

Fixed checkstyle issues in patch v01.

Test cases are not added because, added method calls existing 
getEditLogManifest.

And this is tested in TestJournalNodeSync testcases.


was (Author: bharatviswa):
Fixed checkstyle issues in patch v01.

> Cleanup code in InterQJournalProtocol.proto
> -------------------------------------------
>
>                 Key: HDFS-13073
>                 URL: https://issues.apache.org/jira/browse/HDFS-13073
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>         Attachments: HDFS-13073.00.patch, HDFS-13073.01.patch
>
>
> We can reuse the messages in QJournalProtocol.proto, instead of redefining 
> again in InterQJournalProtocol.proto.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to