[
https://issues.apache.org/jira/browse/HDFS-13097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353492#comment-16353492
]
Surendra Singh Lilhore commented on HDFS-13097:
-----------------------------------------------
Thanks [~rakeshr] for the review comments. Attached another patch addressing
the same.
This patch handles the following comments mentioned in the jira description.
{code}
Comment-1) => Added volatile to spsMode
Comment-2) => created StoragePolicySatisfyManager and moved all the methods
here. Now, BLockManager holds spsManager ref.
Comment-5) => Modified linked list to BlockingQueue
Comment-8) => Moved the methods to StoragePolicySatisfier class
Comment-11) => Removed 'xattr' term
Comment-12) => Done
Comment-15) => Done
Comment-16) => Done
Comment-18) => Made default value to 10
Comment-22) => Handled IOException separately. On IOException, it will continue
running with error log message. On InterruptedException and other run time
exceptions, thread will stop running with proper error msg.
{code}
Appreciate reviews, thanks!
> [SPS]: Fix the branch review comments(Part1)
> --------------------------------------------
>
> Key: HDFS-13097
> URL: https://issues.apache.org/jira/browse/HDFS-13097
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS-10285
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Priority: Major
> Attachments: HDFS-13097-HDFS-10285.01.patch,
> HDFS-13097-HDFS-10285.02.patch
>
>
> Fix the branch review comment.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
