[
https://issues.apache.org/jira/browse/HDFS-12636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355126#comment-16355126
]
Mukul Kumar Singh commented on HDFS-12636:
------------------------------------------
Thanks for working on this [~ljain],
1) OzoneFSInputStream:21, can you please remove the wildcard here and import
the specific functions inside "java.io."
2) OzoneFSOutputStream:57, commit key should be done as part of
outputstream.close(). any reason for the comment there ?
3) ChunkInputStream.java. Please add comments around chunkOffset to explain
that it is the offset of a chunk inside a key.
4) ChunkGroupInputStream.java. Should we add checkNotClosed() for input stream
as well ? Also in the implementation in ChunkGroupOutputStream, should key name
be added as well ?
5) ChunkGroupInputStream.java, 162-164, Can you please add some comments here
7) OzoneFileSystem.java:41, Please remove the wildcards here.
> Ozone: OzoneFileSystem: Implement seek functionality for rpc client
> -------------------------------------------------------------------
>
> Key: HDFS-12636
> URL: https://issues.apache.org/jira/browse/HDFS-12636
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Mukul Kumar Singh
> Assignee: Lokesh Jain
> Priority: Major
> Fix For: HDFS-7240
>
> Attachments: HDFS-12636-HDFS-7240.001.patch,
> HDFS-12636-HDFS-7240.002.patch, HDFS-12636-HDFS-7240.003.patch,
> HDFS-12636-HDFS-7240.004.patch, HDFS-12636-HDFS-7240.005.patch,
> HDFS-12636-HDFS-7240.006.patch
>
>
> OzoneClient library provides a method to invoke both RPC as well as REST
> based methods to ozone. This api will help in the improving both the
> performance as well as the interface management in OzoneFileSystem.
> This jira will be used to convert the REST based calls to use this new
> unified client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
